[Spice-devel] [PATCH spice-protocol] qxl_dev: Add comment to QXLQUICData->data field

Victor Toso victortoso at redhat.com
Thu Aug 22 12:18:04 UTC 2019


Hi,

On Thu, Aug 22, 2019 at 08:14:24AM -0400, Frediano Ziglio wrote:
> ping
> 
> > 
> > Recently a bug using this structure was fixed.
> > The bug involved understand the usage of this field so add some
> > note on the field for future reference.
> > 
> > Signed-off-by: Frediano Ziglio <fziglio at redhat.com>

Sure,
Acked-by: Victor Toso <victortoso at redhat.com>

> > ---
> >  spice/qxl_dev.h | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/spice/qxl_dev.h b/spice/qxl_dev.h
> > index c844d7b..3f56aae 100644
> > --- a/spice/qxl_dev.h
> > +++ b/spice/qxl_dev.h
> > @@ -740,6 +740,9 @@ typedef struct SPICE_ATTR_PACKED QXLSurfaceId {
> >  
> >  typedef struct SPICE_ATTR_PACKED QXLQUICData {
> >      uint32_t data_size;
> > +    /* This data for QUIC is a QXLDataChunk.
> > +     * This differs from QXLBitmap where it's a reference to bitmap data or
> > +     * a reference to QXLDataChunk */
> >      uint8_t data[0];
> >  } QXLQUICData, QXLLZRGBData, QXLJPEGData;
> >  
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20190822/8cc15dfa/attachment.sig>


More information about the Spice-devel mailing list