[Spice-devel] [PATCH spice-gtk v4 11/29] fixup! usb-redir: add files for SCSI and USB MSC implementation

[Frediano Ziglio]

> 
> On Tue, Aug 27, 2019 at 10:22:28AM +0100, Frediano Ziglio wrote:
> > Do not wrap all declarations, keep out external headers
> > ---
> >  src/cd-usb-bulk-msd.h | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/src/cd-usb-bulk-msd.h b/src/cd-usb-bulk-msd.h
> > index 85661165..c165c187 100644
> > --- a/src/cd-usb-bulk-msd.h
> > +++ b/src/cd-usb-bulk-msd.h
> > @@ -21,12 +21,12 @@
> >  
> >  #pragma once
> >  
> > -G_BEGIN_DECLS
> > -
> >  #include <gio/gio.h>
> >  
> >  #include "cd-scsi-dev-params.h"
> >  
> > +G_BEGIN_DECLS
> > +
> 
> Did you get a warning?
> Acked-by: Victor Toso <victortoso at redhat.com>
> 

I didn't compile with C++ but I know how it works.

> >  typedef enum CdUsbBulkStatus {
> >      BULK_STATUS_GOOD = 0,
> >      BULK_STATUS_ERROR,

Frediano