[Spice-devel] [PATCH spice-gtk v4 14/29] fixup! usb-redir: add implementation of emulated CD device

Victor Toso victortoso at redhat.com
Tue Aug 27 12:27:20 UTC 2019


Hi,

On Tue, Aug 27, 2019 at 10:22:31AM +0100, Frediano Ziglio wrote:
> Add comment on constant
> ---
>  src/usb-device-cd.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/usb-device-cd.c b/src/usb-device-cd.c
> index c33bb290..2234289c 100644
> --- a/src/usb-device-cd.c
> +++ b/src/usb-device-cd.c
> @@ -57,6 +57,7 @@ typedef struct SpiceCdLU {
>  
>  #define MAX_LUN_PER_DEVICE              1
>  #define USB2_BCD                        0x200
> +/* Red Hat USB VID */

I don't mind adding a comment but perhaps SPICE USB VID instead?

>  #define CD_DEV_VID                      0x2b23
>  #define CD_DEV_PID                      0xCDCD
>  #define CD_DEV_CLASS                    8
> -- 
> 2.20.1
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20190827/b849e0d4/attachment.sig>


More information about the Spice-devel mailing list