[Spice-devel] [PATCH spice-gtk v4 14/29] fixup! usb-redir: add implementation of emulated CD device

[Victor Toso]

On Tue, Aug 27, 2019 at 10:14:16AM -0400, Frediano Ziglio wrote:
> > 
> > Hi,
> > 
> > On Tue, Aug 27, 2019 at 10:22:31AM +0100, Frediano Ziglio wrote:
> > > Add comment on constant
> > > ---
> > >  src/usb-device-cd.c | 1 +
> > >  1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/src/usb-device-cd.c b/src/usb-device-cd.c
> > > index c33bb290..2234289c 100644
> > > --- a/src/usb-device-cd.c
> > > +++ b/src/usb-device-cd.c
> > > @@ -57,6 +57,7 @@ typedef struct SpiceCdLU {
> > >  
> > >  #define MAX_LUN_PER_DEVICE              1
> > >  #define USB2_BCD                        0x200
> > > +/* Red Hat USB VID */
> > 
> > I don't mind adding a comment but perhaps SPICE USB VID instead?
> > 
> 
> No, SPICE is a project, not a vendor, the 0x2b23 is reserved by USB
> standards for Red Hat, not for SPICE.
> Another reason why the comment make sense :-)

Aha, agree.
Acked-by: Victor Toso <victortoso at redhat.com>

> 
> > >  #define CD_DEV_VID                      0x2b23
> > >  #define CD_DEV_PID                      0xCDCD
> > >  #define CD_DEV_CLASS                    8
> 
> Frediano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20190827/6961fe4a/attachment.sig>