[Spice-devel] [PATCH spice-gtk v4 09/29] usb-redir: add files for SCSI and USB MSC implementation

[Frediano Ziglio]

> 
> Hi,
> 
> On Tue, Aug 27, 2019 at 10:22:26AM +0100, Frediano Ziglio wrote:
> > From: Yuri Benditovich <yuri.benditovich at daynix.com>
> > 
> > Files added without including them in compilation.
> > They contain implementation of SCSI commands for logical
> > units of mass-storage device class and USB bulk-only
> > mass-storage device protocol.
> > 
> > Signed-off-by: Alexander Nezhinsky<anezhins at redhat.com>
> > Signed-off-by: Yuri Benditovich <yuri.benditovich at daynix.com>
> > ---
> >  src/cd-scsi-dev-params.h |   49 +
> >  src/cd-scsi.c            | 2740 ++++++++++++++++++++++++++++++++++++++
> >  src/cd-scsi.h            |  120 ++
> >  src/cd-usb-bulk-msd.c    |  544 ++++++++
> >  src/cd-usb-bulk-msd.h    |  134 ++
> >  src/scsi-constants.h     |  324 +++++
> >  6 files changed, 3911 insertions(+)
> >  create mode 100644 src/cd-scsi-dev-params.h
> >  create mode 100644 src/cd-scsi.c
> >  create mode 100644 src/cd-scsi.h
> >  create mode 100644 src/cd-usb-bulk-msd.c
> >  create mode 100644 src/cd-usb-bulk-msd.h
> >  create mode 100644 src/scsi-constants.h
> 
> A bit upsetting that near 4k insertions comes with commit log of
> two sentences. Not familiar at all with scsi but the idea of how
> that will be used, interfaces, limitations, etc. could come handy
> in the commit log.
> 
> Same goes for the user of this, on patch "usb-redir: add
> implementation of emulated CD device" which only says "This
> module contains implementation of emulated device interface for
> shared CD."
> 

Beside that I'm personally fine with the state of this patch.

Not 100% sure that the code is 100% complaints with SCSI and SPC/MMC
standards but I didn't find big issues.
Maybe I have a small patch to prevent a small issue but can wait.

... omissis ...

Frediano