[Spice-devel] [PATCH spice-gtk] meson: Bump minimum required meson_version to 0.50

[Frediano Ziglio]

> > 
> > On Wed, Aug 28, 2019 at 12:23:23PM -0400, Frediano Ziglio wrote:
> > > > 
> > > > This will drop the following warning:
> > > > "Project specifies a minimum meson_version '>= 0.49' but uses
> > > >  features which were added in newer versions"
> > > > 
> > > > Signed-off-by: Snir Sheriber <ssheribe at redhat.com>
> > > 
> > > Why not 0.51? From repology looks like all distros have less than 0.50 or
> > > at least 0.51.
> > > 
> > > It looks like this warning is a false positive, I don't remember any
> > > significant updates since we bump to 0.49.
> > 
> > The commit message here is truncated from what meson actually reports
> > 
> >   WARNING: Project specifies a minimum meson_version '>= 0.49' but uses
> >   features which were added in newer versions:
> >    * 0.50.0: {'install arg in configure_file'}
> > 
> 
> Looks like this warning is also present in spice-common and spice-server.
> Snir, can you post patches for all these too?
> 

I read better the documentation (for configure_file).
The "install" argument is false by default if install_dir is not provided
so removing install argument will also remove the warning.
The same apply to spice-common.
spice-server instead uses "install_dir" so Meson 0.50 is required for it.

> > The top level meson.build does indeed use this 'install' arg
> > so neeeds 0.50.0.
> > 
> > 
> > Regards,
> > Daniel
> > --
> > |: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange
> > |:|
> > |: https://libvirt.org         -o-            https://fstop138.berrange.com
> > |:|
> > |: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange
> > |:|
> > 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel