[Spice-devel] [PATCH v2 1/1] virtio-video: Add virtio video device specification

Gerd Hoffmann kraxel at redhat.com
Thu Dec 19 12:54:32 UTC 2019


  Hi,

> > I also can't see why the flag is needed in the first place.  The driver
> > should know which buffers are queued still and be able to figure
> > whenever the drain is complete or not without depending on that flag.
> > So I'd suggest to simply drop it.
> This flag is used not for drain only. In marks the completion of whatever 
> specific buffer sequence, like a full end-of-stream, resolution change, drain 
> etc. We also need this to handle nested sequences. For instance, a resolution 
> change event might happen while in drain.

Ah, ok.  That makes sense (please clarify this in the spec).

cheers,
  Gerd



More information about the Spice-devel mailing list