[Spice-devel] [PATCH spice-common 1/4] meson: Use underscorify() instead of split()

Frediano Ziglio fziglio at redhat.com
Mon Feb 4 12:45:15 UTC 2019


> 
> Signed-off-by: Eduardo Lima (Etrunko) <etrunko at redhat.com>
> ---
>  meson.build | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/meson.build b/meson.build
> index 80e4b1c..e26d817 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -164,8 +164,7 @@ endif
>  #
>  # global C defines
>  #
> -glib_major_minor = glib_version.split('.')
> -glib_encoded_version = 'GLIB_VERSION_ at 0@_ at 1@'.format(glib_major_minor[0],
> glib_major_minor[1])
> +glib_encoded_version =
> 'GLIB_VERSION_ at 0@'.format(glib_version.underscorify())
>  spice_common_global_cflags +=
>  ['-DGLIB_VERSION_MIN_REQUIRED=@0@'.format(glib_encoded_version),
>                                 '-DGLIB_VERSION_MAX_ALLOWED=@0@'.format(glib_encoded_version)]
>  

As long as the glib_version is always major.minor (which is currently
the case) the code is equivalent, so

Acked-by: Frediano Ziglio <fziglio at redhat.com>

Frediano


More information about the Spice-devel mailing list