[Spice-devel] [PATCH] spec: call semanage in posttrans not in post

[Christophe Fergeau]

On Tue, Feb 05, 2019 at 01:24:38PM -0500, Frediano Ziglio wrote:
> > On Tue, Feb 05, 2019 at 09:30:39AM -0500, Frediano Ziglio wrote:
> > > > 
> > > > It can happen that selinux-policy (targeted) is installed only after
> > > > spice-streaming-agent (upon system installation). In that case
> > > > running semanage in post scriptlet will fail.
> > > > 
> > > > In posttrans all packages are already installed, so it should be
> > > > safe to call semanage at that point.
> > > > 
> > > > rhbz#1647789
> > > > 
> > > > Signed-off-by: Uri Lublin <uril at redhat.com>
> > > > ---
> > > > 
> > > > In a first patch I wrote I also added a condition that
> > > > checks if selinuxenabled. If people feel it's better
> > > > I'll send a V2 with it.
> > > > 
> > > 
> > > I see no reason why adding to selinux-policy should be a stopover
> > > for this fix in the meanwhile.
> > > 
> > > Acked-by: Frediano Ziglio <fziglio at redhat.com>
> > 
> > Ensuring that a bug is fixed in the right place, and explaining this in
> > the commit log should be a stopper though.
> > 
> > Christophe
> > 
> 
> It's not clear what you are suggesting.
> Adding a sentence in the commit message?

Did we file a selinux bug asking for this addition?
If yes, where is this bug?
And yes, if the right fix is for this hypothetical bug to be fixed, then
this should be explained in the commit log.

However, I think spice-streaming-agent is not yet available in Fedora ?
In which case it would be too early for the aforementioned bug I think
:-/

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20190206/06d25076/attachment.sig>