[Spice-devel] [spice-server 1/3] smartcard: Remove unused smartcard_get_vsc_msg_item argument

[Frediano Ziglio]

> 
> ---
>  server/smartcard.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/server/smartcard.c b/server/smartcard.c
> index 4c8494500..95dd90108 100644
> --- a/server/smartcard.c
> +++ b/server/smartcard.c
> @@ -108,7 +108,7 @@ typedef struct RedMsgItem {
>      VSCMsgHeader* vheader;
>  } RedMsgItem;
>  
> -static RedMsgItem *smartcard_get_vsc_msg_item(RedChannelClient *rcc,
> VSCMsgHeader *vheader);
> +static RedMsgItem *smartcard_get_vsc_msg_item(VSCMsgHeader *vheader);
>  
>  static struct Readers {
>      uint32_t num;
> @@ -229,8 +229,7 @@ RedMsgItem
> *smartcard_char_device_on_message_from_device(RedCharDeviceSmartcard
>          /* We patch the reader_id, since the device only knows about itself,
>          and
>           * we know about the sum of readers. */
>          sent_header->reader_id = dev->priv->reader_id;
> -        return
> smartcard_get_vsc_msg_item(RED_CHANNEL_CLIENT(dev->priv->scc),
> -                                          sent_header);
> +        return smartcard_get_vsc_msg_item(sent_header);
>      }
>      return NULL;
>  }
> @@ -469,8 +468,7 @@ static void smartcard_free_vsc_msg_item(RedPipeItem
> *base)
>      g_free(item);
>  }
>  
> -static RedMsgItem *smartcard_get_vsc_msg_item(RedChannelClient *rcc,
> -                                              VSCMsgHeader *vheader)
> +static RedMsgItem *smartcard_get_vsc_msg_item(VSCMsgHeader *vheader)

Maybe _get_ -> _new_ ?
Does the smartcard_ prefix give any value?

>  {
>      RedMsgItem *msg_item = g_new0(RedMsgItem, 1);
>  

Otherwise,
Acked-by: Frediano Ziglio <fziglio at redhat.com>

Frediano