[Spice-devel] [PATCH spice-server] fixup! Update usage of GObject private structures

Eduardo Lima (Etrunko) etrunko at redhat.com
Thu Feb 7 18:49:32 UTC 2019


On 2/7/19 2:42 PM, Frediano Ziglio wrote:
> Split long lines.

Sorry, I forgot to break the lines, my bad. I will squash this one as
well...

Small tip, next time you could use the --in-reply-to="<msg_id>" option
for git-send-email to keep the context, especially, with fixup patches
like this one.

Thank you, Eduardo.

> 
> ---
>  server/common-graphics-channel.c | 6 ++++--
>  server/cursor-channel-client.c   | 3 ++-
>  2 files changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/server/common-graphics-channel.c b/server/common-graphics-channel.c
> index 1bf44fee..b70fa3a4 100644
> --- a/server/common-graphics-channel.c
> +++ b/server/common-graphics-channel.c
> @@ -35,13 +35,15 @@ struct CommonGraphicsChannelPrivate
>                                    of the primary surface) */
>  };
>  
> -G_DEFINE_ABSTRACT_TYPE_WITH_PRIVATE(CommonGraphicsChannel, common_graphics_channel, RED_TYPE_CHANNEL)
> +G_DEFINE_ABSTRACT_TYPE_WITH_PRIVATE(CommonGraphicsChannel, common_graphics_channel,
> +                                    RED_TYPE_CHANNEL)
>  
>  struct CommonGraphicsChannelClientPrivate {
>      uint8_t recv_buf[CHANNEL_RECEIVE_BUF_SIZE];
>  };
>  
> -G_DEFINE_TYPE_WITH_PRIVATE(CommonGraphicsChannelClient, common_graphics_channel_client, RED_TYPE_CHANNEL_CLIENT)
> +G_DEFINE_TYPE_WITH_PRIVATE(CommonGraphicsChannelClient, common_graphics_channel_client,
> +                           RED_TYPE_CHANNEL_CLIENT)
>  
>  static uint8_t *common_alloc_recv_buf(RedChannelClient *rcc, uint16_t type, uint32_t size)
>  {
> diff --git a/server/cursor-channel-client.c b/server/cursor-channel-client.c
> index dfe1b13d..d72989ab 100644
> --- a/server/cursor-channel-client.c
> +++ b/server/cursor-channel-client.c
> @@ -43,7 +43,8 @@ struct CursorChannelClientPrivate
>      uint32_t cursor_cache_items;
>  };
>  
> -G_DEFINE_TYPE_WITH_PRIVATE(CursorChannelClient, cursor_channel_client, TYPE_COMMON_GRAPHICS_CHANNEL_CLIENT)
> +G_DEFINE_TYPE_WITH_PRIVATE(CursorChannelClient, cursor_channel_client,
> +                           TYPE_COMMON_GRAPHICS_CHANNEL_CLIENT)
>  
>  static void cursor_channel_client_on_disconnect(RedChannelClient *rcc);
>  
> 


-- 
Eduardo de Barros Lima (Etrunko)
Software Engineer - RedHat
etrunko at redhat.com


More information about the Spice-devel mailing list