[Spice-devel] [PATCH spice-server 1/8] smartcard-channel-client: Update usage of GObject private structures

[Eduardo Lima (Etrunko)]

On 2/11/19 9:54 AM, Frediano Ziglio wrote:
> This finished the work of 90ff154b36b3ab80350cb4a4d391db330bed2a76
> (cfr "Update usage of GObject private structures").
> Removes last call to g_type_class_add_private.
> 
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> ---
>  server/smartcard-channel-client.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/server/smartcard-channel-client.c b/server/smartcard-channel-client.c
> index a665e9333..daa20ffc4 100644
> --- a/server/smartcard-channel-client.c
> +++ b/server/smartcard-channel-client.c
> @@ -20,8 +20,6 @@
>  
>  #include "smartcard-channel-client.h"
>  
> -G_DEFINE_TYPE(SmartCardChannelClient, smart_card_channel_client, RED_TYPE_CHANNEL_CLIENT)
> -
>  struct SmartCardChannelClientPrivate
>  {
>      RedCharDeviceSmartcard *smartcard;
> @@ -33,6 +31,9 @@ struct SmartCardChannelClientPrivate
>                             * or was it explicitly malloced */
>  };
>  
> +G_DEFINE_TYPE_WITH_PRIVATE(SmartCardChannelClient, smart_card_channel_client,
> +                           RED_TYPE_CHANNEL_CLIENT)
> +
>  typedef struct RedErrorItem {
>      RedPipeItem base;
>      VSCMsgHeader vheader;
> @@ -84,8 +85,6 @@ static void smart_card_channel_client_class_init(SmartCardChannelClientClass *kl
>  {
>      GObjectClass *object_class = G_OBJECT_CLASS(klass);
>  
> -    g_type_class_add_private(klass, sizeof(SmartCardChannelClientPrivate));
> -
>      RedChannelClientClass *client_class = RED_CHANNEL_CLIENT_CLASS(klass);
>      client_class->alloc_recv_buf = smartcard_channel_client_alloc_msg_rcv_buf;
>      client_class->release_recv_buf = smartcard_channel_client_release_msg_rcv_buf;
> 

Strange, dunno how I missed this one :)

Acked-by: Eduardo Lima (Etrunko) <etrunko at redhat.com>

-- 
Eduardo de Barros Lima (Etrunko)
Software Engineer - RedHat
etrunko at redhat.com