[Spice-devel] [PATCH spice-server v2 1/3] meson: Use gnu_symbol_visibility keyword introduced in meson 0.48

Frediano Ziglio fziglio at redhat.com
Wed Feb 13 17:01:25 UTC 2019


> 
> Signed-off-by: Eduardo Lima (Etrunko) <etrunko at redhat.com>

For the series:

Acked-by: Frediano Ziglio <fziglio at redhat.com>

> ---
>  meson.build        | 5 ++---
>  server/meson.build | 3 ++-
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/meson.build b/meson.build
> index 811099c6..459409f6 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -4,7 +4,7 @@
>  project('spice', 'c',
>          version : run_command('build-aux/git-version-gen',
>          '${MESON_SOURCE_ROOT}/.tarball-version', check :
>          true).stdout().strip(),
>          license : 'LGPLv2.1',
> -        meson_version : '>= 0.47.2')
> +        meson_version : '>= 0.48')
>  
>  message('Updating submodules')
>  run_command('build-aux/meson/check-spice-common', check : true)
> @@ -36,8 +36,7 @@ spice_server_so_version =
> '@0 at .@1 at .@2@'.format(spice_server_current - spice_serv
>  message('libspice.so version: ' + spice_server_so_version)
>  
>  # some global vars
> -spice_server_global_cflags = ['-fvisibility=hidden',
> -                              '-DSPICE_SERVER_INTERNAL',
> +spice_server_global_cflags = ['-DSPICE_SERVER_INTERNAL',
>                                '-DG_LOG_DOMAIN="Spice"',
>                                '-DHAVE_CONFIG_H',
>                                #'-Werror',
> diff --git a/server/meson.build b/server/meson.build
> index 2c024120..63191d79 100644
> --- a/server/meson.build
> +++ b/server/meson.build
> @@ -179,7 +179,8 @@ spice_server_libs = both_libraries('spice-server',
> spice_server_sources,
>                                     include_directories :
>                                     spice_server_include,
>                                     link_args :
>                                     compiler.get_supported_link_arguments(spice_server_link_args),
>                                     link_depends : spice_server_syms,
> -                                   dependencies : spice_server_deps)
> +                                   dependencies : spice_server_deps,
> +                                   gnu_symbol_visibility : 'hidden')
>  
>  spice_server_shared_lib = spice_server_libs.get_shared_lib()
>  spice_server_static_lib = spice_server_libs.get_static_lib()


More information about the Spice-devel mailing list