[Spice-devel] [spice-html5][PATCH 00/12] Prepare for npmjs publication

[Jeremy White]

Hi Cédric,

Thank you for this!  This is very useful work, and I appreciate you 
taking the time to work on it.

I've been through all of the patches, and I think everything looks great.

However, your 02 patch in this sequence has a lot of trailing white 
space; could you eliminate that?

Also, I think in honoring my request to remove the es5 compatibility, 
you introduced what is probably a trivial bug.  I haven't had time to 
explore it, but I get a ReferenceError: SpiceHtml5 is not defined error 
when I try to start a session.  Hopefully that is also an easy fix.

I look forward to getting this sequence into Spice.

Cheers,

Jeremy

On 2/11/19 11:47 AM, Cédric Bosdonnat wrote:
> Hi Jeremy, all,
> 
> Here is the series that moves everything into a module and avoid
> cluttering the global namespace. This also includes some fixes for
> bugs I found while integrating in a third party website.
> 
> Cédric Bosdonnat (12):
>    CSS: don't force the background color or inputs
>    Introduce ES6 modules
>    Remove duplicated enums
>    Expose all needed pieces in main.js
>    Prepare publishing on npmjs
>    Move sources into their own folder
>    Fix disconnect() code
>    Prompt password in spice_auto.html
>    Document onsuccess callback
>    resize_helper, no message box case
>    resize_helper: round sizes down
>    More reliable mouse position reporting
> 
>   TODO                                          |     3 -
>   atKeynames.js                                 |   183 -
>   enums.js                                      |   377 -
>   package.json                                  |    21 +
>   spice.css                                     |     1 -
>   spice.html                                    |    67 +-
>   spice_auto.html                               |    79 +-
>   src/atKeynames.js                             |   189 +
>   bitmap.js => src/bitmap.js                    |    15 +-
>   cursor.js => src/cursor.js                    |    35 +-
>   display.js => src/display.js                  |   282 +-
>   src/enums.js                                  |   372 +
>   filexfer.js => src/filexfer.js                |     6 +
>   inputs.js => src/inputs.js                    |   128 +-
>   lz.js => src/lz.js                            |    28 +-
>   main.js => src/main.js                        |   152 +-
>   playback.js => src/playback.js                |    95 +-
>   png.js => src/png.js                          |     6 +
>   port.js => src/port.js                        |    15 +-
>   quic.js => src/quic.js                        |    51 +-
>   resize.js => src/resize.js                    |    34 +-
>   simulatecursor.js => src/simulatecursor.js    |     6 +
>   .../spicearraybuffer.js                       |     0
>   spiceconn.js => src/spiceconn.js              |   107 +-
>   spicedataview.js => src/spicedataview.js      |     4 +
>   spicemsg.js => src/spicemsg.js                |   113 +-
>   spicetype.js => src/spicetype.js              |    46 +-
>   .../browser-es-module-loader/.npmignore       |     0
>   .../browser-es-module-loader/README.md        |    15 +
>   .../dist/babel-worker.js                      | 55799 ++++++++++++++++
>   .../dist/browser-es-module-loader.js          |  1486 +
>   .../dist/browser-es-module-loader.js.map      |     1 +
>   .../browser-es-module-loader/rollup.config.js |    16 +
>   .../src/babel-worker.js                       |    25 +
>   .../src/browser-es-module-loader.js           |   280 +
>   {thirdparty => src/thirdparty}/jsbn.js        |     4 +
>   {thirdparty => src/thirdparty}/prng4.js       |     5 +
>   {thirdparty => src/thirdparty}/rng.js         |     5 +
>   {thirdparty => src/thirdparty}/rsa.js         |     7 +
>   {thirdparty => src/thirdparty}/sha1.js        |     5 +
>   ticket.js => src/ticket.js                    |    10 +
>   utils.js => src/utils.js                      |   199 +-
>   webm.js => src/webm.js                        |    38 +-
>   wire.js => src/wire.js                        |     8 +
>   44 files changed, 59140 insertions(+), 1178 deletions(-)
>   delete mode 100644 atKeynames.js
>   delete mode 100644 enums.js
>   create mode 100644 package.json
>   create mode 100644 src/atKeynames.js
>   rename bitmap.js => src/bitmap.js (84%)
>   rename cursor.js => src/cursor.js (79%)
>   rename display.js => src/display.js (81%)
>   create mode 100644 src/enums.js
>   rename filexfer.js => src/filexfer.js (97%)
>   rename inputs.js => src/inputs.js (62%)
>   rename lz.js => src/lz.js (85%)
>   rename main.js => src/main.js (69%)
>   rename playback.js => src/playback.js (76%)
>   rename png.js => src/png.js (98%)
>   rename port.js => src/port.js (88%)
>   rename quic.js => src/quic.js (97%)
>   rename resize.js => src/resize.js (77%)
>   rename simulatecursor.js => src/simulatecursor.js (98%)
>   rename spicearraybuffer.js => src/spicearraybuffer.js (100%)
>   rename spiceconn.js => src/spiceconn.js (82%)
>   rename spicedataview.js => src/spicedataview.js (99%)
>   rename spicemsg.js => src/spicemsg.js (92%)
>   rename spicetype.js => src/spicetype.js (91%)
>   create mode 100644 src/thirdparty/browser-es-module-loader/.npmignore
>   create mode 100644 src/thirdparty/browser-es-module-loader/README.md
>   create mode 100644 src/thirdparty/browser-es-module-loader/dist/babel-worker.js
>   create mode 100644 src/thirdparty/browser-es-module-loader/dist/browser-es-module-loader.js
>   create mode 100644 src/thirdparty/browser-es-module-loader/dist/browser-es-module-loader.js.map
>   create mode 100644 src/thirdparty/browser-es-module-loader/rollup.config.js
>   create mode 100644 src/thirdparty/browser-es-module-loader/src/babel-worker.js
>   create mode 100644 src/thirdparty/browser-es-module-loader/src/browser-es-module-loader.js
>   rename {thirdparty => src/thirdparty}/jsbn.js (99%)
>   rename {thirdparty => src/thirdparty}/prng4.js (98%)
>   rename {thirdparty => src/thirdparty}/rng.js (97%)
>   rename {thirdparty => src/thirdparty}/rsa.js (96%)
>   rename {thirdparty => src/thirdparty}/sha1.js (96%)
>   rename ticket.js => src/ticket.js (96%)
>   rename utils.js => src/utils.js (58%)
>   rename webm.js => src/webm.js (95%)
>   rename wire.js => src/wire.js (97%)
>