[Spice-devel] [PATCH spice-gtk v2] channel-display-gst: Use recorder for frame statistics

[Victor Toso]

Hi,

On Tue, Feb 19, 2019 at 05:37:38PM +0100, Marc-André Lureau wrote:
> > > > -        SPICE_DEBUG("frame mm_time %u size %u creation time %"
> > > > G_GINT64_FORMAT
> > > > -                    " decoded time %" G_GINT64_FORMAT " queue %u",
> > > > -                    frame->mm_time, frame->size, frame->creation_time,
> > > > -                    duration, decoder->decoding_queue->length);
> > > > +        record(frames_stats,
> > > > +               "frame mm_time %u size %u creation time %" PRId64
> > > > +               " decoded time %" PRId64 " queue %u",
> > > > +               frame->mm_time, frame->size, frame->creation_time,
> > > > +               duration, decoder->decoding_queue->length);
> > >
> > > Why SPICE_DEBUG log is removed?
> > >
> > > Why is the "recorder" stuff necessary here?
> > >
> >
> > Measurement instrumentation
> 
> Ok, but can we get have the regular log as well?

This really is measurement type of logs. We don't have structured
logging so I do prefer this kind of logging being enabled by some
dynamic tweaking instead of seeing it all the time.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20190219/0c18d436/attachment.sig>