[Spice-devel] [PATCH spice-gtk v2] channel-display-gst: Use recorder for frame statistics

[Victor Toso]

Hi,

On Tue, Feb 19, 2019 at 06:12:45PM +0100, Marc-André Lureau wrote:
> Hi
> 
> On Tue, Feb 19, 2019 at 6:02 PM Victor Toso <victortoso at redhat.com> wrote:
> >
> > Hi,
> >
> > On Tue, Feb 19, 2019 at 05:37:38PM +0100, Marc-André Lureau wrote:
> > > > > > -        SPICE_DEBUG("frame mm_time %u size %u creation time %"
> > > > > > G_GINT64_FORMAT
> > > > > > -                    " decoded time %" G_GINT64_FORMAT " queue %u",
> > > > > > -                    frame->mm_time, frame->size, frame->creation_time,
> > > > > > -                    duration, decoder->decoding_queue->length);
> > > > > > +        record(frames_stats,
> > > > > > +               "frame mm_time %u size %u creation time %" PRId64
> > > > > > +               " decoded time %" PRId64 " queue %u",
> > > > > > +               frame->mm_time, frame->size, frame->creation_time,
> > > > > > +               duration, decoder->decoding_queue->length);
> > > > >
> > > > > Why SPICE_DEBUG log is removed?
> > > > >
> > > > > Why is the "recorder" stuff necessary here?
> > > > >
> > > >
> > > > Measurement instrumentation
> > >
> > > Ok, but can we get have the regular log as well?
> >
> > This really is measurement type of logs. We don't have structured
> 
> And "trace"(?) are better than "log" for "measurements"?

Feel free to revisit old discussions and start any new
discussions about that with c3d, I think (I hope) he'll be happy
to talk about it.  My take is that, recorder is an extra tool,
useful for some. That's enough for me.
 
> > logging so I do prefer this kind of logging being enabled by some
> > dynamic tweaking instead of seeing it all the time.
> 
> You can filter it out with grep, fairly easily.
>
> I proposed a series using structured logging and categories for
> SPICE_DEBUG= in the past iirc. I guess I should revisit it.

Problem was about bumping and using a too new glib, I think.
Shouldn't be a problem anymore.

    https://gitlab.freedesktop.org/spice/spice-gtk/issues/10

Cheers,
Victor
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20190220/25dffcf1/attachment.sig>