[Spice-devel] [vdagent-linux PATCH v2] Makefile.am: define check_PROGRAMS once

Uri Lublin uril at redhat.com
Wed Feb 20 13:46:35 UTC 2019


Also define TESTS once

autoreconf complains when there are multiple definitions of
a variable. In this case (partial error message follows):
    warning: check_PROGRAMS multiply defined

Signed-off-by: Uri Lublin <uril at redhat.com>
---

changes since v1:
  - Instead of having a single check_PROGRAMS at the top,
    use += to add tests to check_PROGRAMS (Frediano)

---
 Makefile.am | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/Makefile.am b/Makefile.am
index c2e9668..a39a40e 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -167,9 +167,4 @@ DISTCHECK_CONFIGURE_FLAGS =			\
 tests_test_device_info_LDADD = $(src_spice_vdagent_LDADD)
 tests_test_device_info_CFLAGS = $(src_spice_vdagent_CFLAGS)
 
-check_PROGRAMS = 					\
-	tests/test-device-info			\
-	$(NULL)
-
-TESTS = $(check_PROGRAMS)
-
+check_PROGRAMS += tests/test-device-info
-- 
2.20.1



More information about the Spice-devel mailing list