[Spice-devel] [PATCH spice-gtk] build-sys: Use always --buildtype=release

[Jonathon Jongsma]

On Wed, 2019-02-20 at 15:50 -0500, Frediano Ziglio wrote:
> > 
> > On Thu, 2019-02-14 at 12:56 +0000, Frediano Ziglio wrote:
> > > Allows to catch some errors which the compiler is not able to
> > > detect in debug mode (the default).
> > 
> > Seems fine, but what kind of errors are you talking about?
> > Reviewed-by: Jonathon Jongsma <jjongsma at redhat.com>
> > 
> 
> Like "this variable is not used" or "this variable is not
> initialized"
> for instance.
> Not sure if people prefers "release" or "debugoptimized" but without
> optimizations compilers cannot detect some potential issues.

Since this is just for the CI stuff, I don't really have a problem with
using the release buildtype. I'm not sure that debugoptimized provides
much advantage in this situation. But it'd be nice if the commit log
said something about optimization. e.g.

"Allows the compiler to catch some errors which are only triggered when
building with optimizations enabled"?

Jonathon


> 
> Frediano
> 
> > 
> > > 
> > > Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> > > ---
> > >  .gitlab-ci.yml | 10 +++++-----
> > >  1 file changed, 5 insertions(+), 5 deletions(-)
> > > 
> > > https://gitlab.freedesktop.org/fziglio/spice-gtk/pipelines/19157
> > > (only Meson builds)
> > > 
> > > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> > > index 8ffc6542..adf53e1c 100644
> > > --- a/.gitlab-ci.yml
> > > +++ b/.gitlab-ci.yml
> > > @@ -57,15 +57,15 @@ fedora-meson:
> > >    before_script:
> > >      - dnf install -y $DEPS_COMMON $DEPS_FEDORA
> > >      - git clone ${CI_REPOSITORY_URL/spice-gtk/spice-protocol}
> > > -    - meson spice-protocol build-spice-protocol --prefix=/usr
> > > +    - meson --buildtype=release spice-protocol build-spice-
> > > protocol
> > > --prefix=/usr
> > >      - ninja -C build-spice-protocol install
> > >  
> > >    script:
> > > -    - meson build-default
> > > +    - meson --buildtype=release build-default
> > >      - ninja -C build-default
> > >      - ninja -C build-default test
> > >  
> > > -    - meson build-feat-disabled -Dauto_features=disabled
> > > +    - meson --buildtype=release build-feat-disabled
> > > -Dauto_features=disabled
> > >      - ninja -C build-feat-disabled
> > >      - ninja -C build-feat-disabled test
> > >  
> > > @@ -92,11 +92,11 @@ windows-meson:
> > >      - dnf install -y $DEPS_COMMON $DEPS_MINGW
> > >      - git clone ${CI_REPOSITORY_URL/spice-gtk/spice-protocol}
> > >      - mkdir spice-protocol/build-spice-protocol && cd spice-
> > > protocol/build-spice-protocol
> > > -    - mingw64-meson --prefix=/usr
> > > +    - mingw64-meson --buildtype=release --prefix=/usr
> > >      - ninja install
> > >  
> > >    script:
> > >      - cd $CI_PROJECT_DIR
> > >      - mkdir build-win64 && cd build-win64
> > > -    - mingw64-meson -Dgtk_doc=disabled
> > > +    - mingw64-meson --buildtype=release -Dgtk_doc=disabled
> > >      - ninja install
> > 
> >