[Spice-devel] [PATCH spice-gtk v2] build-sys: Use always --buildtype=release

[Jonathon Jongsma]

On additional minor change that I would like: it would be nice if the
commit summary indicated that this is only for the gitlab CI
configuration. "build-sys: Use always --buildtype=release" makes it
sound like the change forces all developers to build in release mode.


Otherwise,
Acked-by: Jonathon Jongsma <jjongsma at redhat.com>


On Thu, 2019-02-21 at 15:59 +0000, Frediano Ziglio wrote:
> Allows the compiler to catch some errors which are only triggered
> when
> building with optimizations enabled.
> 
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> ---
>  .gitlab-ci.yml | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index 8ffc6542..adf53e1c 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -57,15 +57,15 @@ fedora-meson:
>    before_script:
>      - dnf install -y $DEPS_COMMON $DEPS_FEDORA
>      - git clone ${CI_REPOSITORY_URL/spice-gtk/spice-protocol}
> -    - meson spice-protocol build-spice-protocol --prefix=/usr
> +    - meson --buildtype=release spice-protocol build-spice-protocol
> --prefix=/usr
>      - ninja -C build-spice-protocol install
>  
>    script:
> -    - meson build-default
> +    - meson --buildtype=release build-default
>      - ninja -C build-default
>      - ninja -C build-default test
>  
> -    - meson build-feat-disabled -Dauto_features=disabled
> +    - meson --buildtype=release build-feat-disabled
> -Dauto_features=disabled
>      - ninja -C build-feat-disabled
>      - ninja -C build-feat-disabled test
>  
> @@ -92,11 +92,11 @@ windows-meson:
>      - dnf install -y $DEPS_COMMON $DEPS_MINGW
>      - git clone ${CI_REPOSITORY_URL/spice-gtk/spice-protocol}
>      - mkdir spice-protocol/build-spice-protocol && cd spice-
> protocol/build-spice-protocol
> -    - mingw64-meson --prefix=/usr
> +    - mingw64-meson --buildtype=release --prefix=/usr
>      - ninja install
>  
>    script:
>      - cd $CI_PROJECT_DIR
>      - mkdir build-win64 && cd build-win64
> -    - mingw64-meson -Dgtk_doc=disabled
> +    - mingw64-meson --buildtype=release -Dgtk_doc=disabled
>      - ninja install