[Spice-devel] [spice-gtk 2/2] win-usb-dev: remove ifdef for libusb on 1.0.13

Victor Toso victortoso at redhat.com
Fri Feb 22 17:38:17 UTC 2019


On Fri, Feb 22, 2019 at 05:31:33PM +0000, Victor Toso wrote:
> From: Victor Toso <me at victortoso.com>
> 
> We already require libusb 1.0.16 or above since 8269a5be62f4ce1
> (build-sys: drop support for libusb < 1.0.16)
> 
> Signed-off-by: Victor Toso <victortoso at redhat.com>
> ---
>  src/win-usb-dev.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/src/win-usb-dev.c b/src/win-usb-dev.c
> index 327976d..934a55b 100644
> --- a/src/win-usb-dev.c
> +++ b/src/win-usb-dev.c
> @@ -570,9 +570,7 @@ static gboolean g_udev_skip_search(GUdevDevice *udev)
>      g_return_val_if_fail(udevinfo != NULL, FALSE);
>  
>      skip = ((udevinfo->addr == 0xff) ||  /* root hub (HCD) */
> -#if defined(LIBUSBX_API_VERSION) && (LIBUSBX_API_VERSION >= 0x010000FF)
>              (udevinfo->addr == 1) || /* root hub addr for libusbx >= 1.0.13 */
> -#endif

Should be fine to remove the comment as well, oh well, better to
send v2, sorry about noise

>              (udevinfo->class == LIBUSB_CLASS_HUB) || /* hub*/
>              (udevinfo->addr == 0)); /* bad address */
>      return skip;
> -- 
> 2.20.1
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20190222/6c66a35a/attachment.sig>


More information about the Spice-devel mailing list