[Spice-devel] [PATCH spice-server] Do not use possibly undefined SPICE_CHANNEL_TUNNEL

[Victor Toso]

Hi,

On Mon, Feb 25, 2019 at 08:37:23AM +0000, Frediano Ziglio wrote:
> The channel was removed from the protocol and marked as
> obsolete. Potentially will be removed from spice/enums.h
> when regenerated.

Should it really be removed?

> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> ---
>  server/utils.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/server/utils.c b/server/utils.c
> index b440c0648..d2d3669bd 100644
> --- a/server/utils.c
> +++ b/server/utils.c
> @@ -62,7 +62,7 @@ static const char *const channel_names[] = {
>      [ SPICE_CHANNEL_CURSOR   ] = "cursor",
>      [ SPICE_CHANNEL_PLAYBACK ] = "playback",
>      [ SPICE_CHANNEL_RECORD   ] = "record",
> -    [ SPICE_CHANNEL_TUNNEL   ] = "tunnel",
> +    [ 7 /* SPICE_CHANNEL_TUNNEL */ ] = "tunnel",

I think this is fine anyway.
Acked-by: Victor Toso <victortoso at redhat.com>

>      [ SPICE_CHANNEL_SMARTCARD] = "smartcard",
>      [ SPICE_CHANNEL_USBREDIR ] = "usbredir",
>      [ SPICE_CHANNEL_PORT     ] = "port",
> -- 
> 2.20.1
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20190225/63b9fc27/attachment.sig>