[Spice-devel] [PATCH 1/3] Add copr Makefile

[Frediano Ziglio]

> ---
>  .copr/Makefile | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
>  create mode 100644 .copr/Makefile
> 
> diff --git a/.copr/Makefile b/.copr/Makefile
> new file mode 100644
> index 0000000..53b1b1b
> --- /dev/null
> +++ b/.copr/Makefile
> @@ -0,0 +1,21 @@
> +PROTOCOL_GIT_REPO = https://gitlab.freedesktop.org/spice/spice-protocol
> +BUILD = make automake autoconf autoconf-archive libtool xz gcc-c++ fedpkg
> +
> +srpm:
> +	dnf install -y $(BUILD)
> +
> +	# get upstream spice protocol
> +	git clone $(PROTOCOL_GIT_REPO)
> +	cd spice-protocol ; ./autogen.sh ; make install

I would use && to avoid ignoring error and a /usr prefix:

	cd spice-protocol && ./autogen.sh --prefix=/usr && make install

> +
> +	# get dependencies
> +	dnf install -y `grep BuildRequires\: spice-streaming-agent.spec.in | awk
> '{$$1=""; print $$0}' | sed "s/\bspice-protocol\b// ; s/>.*//" | tr -s "\n"
> " "`

it got me a bit of time to read, why not:

	dnf install -y `sed '/^BuildRequires:/!d; s/.*://; s/\bspice-protocol\b//; s/>.*//' spice-streaming-agent.spec.in`

the tr command is not needed, when expanded the shell will strip and
collapse the spaces, by default IFS contains a space, a tab and a new line.

> +	# build this project
> +	PKG_CONFIG_PATH=/usr/local/share/pkgconfig ./autogen.sh

With the change above (prefix), just

       ./autogen.sh

> +
> +	# create source rpm
> +	sed -i -E "s/(^Release:[[:space:]]*)([^%]*)/\1`date
> +'%Y%m%d%H%M.spice.nigthly'`/" spice-streaming-agent.spec
> +	make dist
> +	md5sum *tar* | head -n1 > "sources"

I would be a bit more specific with a

       md5sum *.tar.xz | head -n1 > "sources"

I remember I had some hard time with some machines which were
ordering in a different way the files as the language were
different from my machine.

> +	fedpkg --release "epel7" --path . srpm

Here "--path ." is the default

> +	cp *src.rpm $(outdir)

Frediano