[Spice-devel] [linux/vd-agent 3/3] gitlab-ci: run singular job for build options

Victor Toso victortoso at redhat.com
Wed Feb 27 13:46:38 UTC 2019


On Wed, Feb 27, 2019 at 07:52:11AM -0500, Frediano Ziglio wrote:
> > 
> > From: Victor Toso <me at victortoso.com>
> > 
> > There are two main bottlenecks in CI:
> > 1. Network might be slow for bootstrapping;
> > 2. Big job queues to get a runners to run our jobs.
> > 
> > This patch reduces the three jobs to a single one in order to prevent
> > long delays when CI resources are scarce which is a common scenario.
> > 
> > No major losses in log should happen. We might add specific .log
> > files as artifacts if we need them later on.
> > 
> > Signed-off-by: Victor Toso <victortoso at redhat.com>
> > ---
> >  .gitlab-ci.yml | 6 +-----
> >  1 file changed, 1 insertion(+), 5 deletions(-)
> > 
> > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> > index fc40c04..5de96f8 100644
> > --- a/.gitlab-ci.yml
> > +++ b/.gitlab-ci.yml
> > @@ -12,7 +12,7 @@ before_script:
> >    - git clone ${CI_REPOSITORY_URL/vd_agent/spice-protocol}
> >    - (cd spice-protocol && ./autogen.sh --prefix=/usr && make install)
> >  
> > -make-check-distcheck:
> > +fedora-autotools:
> >    script:
> >    - ./autogen.sh
> >    - make
> > @@ -20,8 +20,6 @@ make-check-distcheck:
> >    - make distcheck
> >    - make distclean
> >  
> > -configure-optional-packages:
> > -  script:
> 
> There are already some "make distclean" in the middle
> which is good. What about something like a
> "git clean -fdx" ?

Either way is fine for me. I trust git more so I'll resubmit soon
:)

Thanks for the reviews

> >    - ./autogen.sh --with-session-info=systemd
> >    --with-init-script=systemd+redhat
> >    - make
> >    - make install
> > @@ -34,8 +32,6 @@ configure-optional-packages:
> >    - make uninstall
> >    - make distclean
> >  
> > -configure-without-optionals:
> > -  script:
> >    - ./autogen.sh --with-gtk=no --with-session-info=none
> >    - make
> >    - make install
> 
> Frediano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20190227/49aa4b32/attachment.sig>


More information about the Spice-devel mailing list