[Spice-devel] [linux/vd-agent 2/3] gitlab-ci: Move the dependencies to a variable

[Frediano Ziglio]

> 
> Hi,
> 
> On Wed, Feb 27, 2019 at 07:49:20AM -0500, Frediano Ziglio wrote:
> > > 
> > > From: Victor Toso <me at victortoso.com>
> > > 
> > > Signed-off-by: Victor Toso <victortoso at redhat.com>
> > > ---
> > >  .gitlab-ci.yml | 16 ++++++++++------
> > >  1 file changed, 10 insertions(+), 6 deletions(-)
> > > 
> > > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> > > index ad4fb80..fc40c04 100644
> > > --- a/.gitlab-ci.yml
> > > +++ b/.gitlab-ci.yml
> > > @@ -1,12 +1,16 @@
> > >  image: fedora:latest
> > >  
> > > +variables:
> > > +  DEPS_COMMON: git libtool make python3 python3-six redhat-rpm-config
> > > +      bzip2 python3-pyparsing meson ninja-build gtk-doc glib2-devel
> > > +      gettext gettext-devel libpciaccess-devel alsa-lib-devel
> > > +      libXfixes-devel libX11-devel libXrandr-devel libXinerama-devel
> > > +      gtk3-devel dbus-devel systemd-devel
> > > +
> > >  before_script:
> > > -  - >
> > > -    dnf install 'dnf-command(copr)' git libtool make redhat-rpm-config
> > > bzip2
> > > -    python3 python3-six python3-pyparsing
> > > -    -y
> > > -  - dnf copr enable @spice/nightly -y
> > > -  - dnf builddep spice-vdagent -y
> > > +  - dnf install -y $DEPS_COMMON
> > > +  - git clone ${CI_REPOSITORY_URL/vd_agent/spice-protocol}
> > > +  - (cd spice-protocol && ./autogen.sh --prefix=/usr && make install)
> > >  
> > >  make-check-distcheck:
> > >    script:
> > 
> > I believe it works but this patch does a lot more than just
> > moving some values to a variable.
> > It actually remove the dependency from copr which is much more
> > important.
> 
> Yes, it was on purpose that I did it but I forgot to split the
> patch. Now I'm not sure if worth to split or just update commit
> log, what do you think?
> 

An update to the commit message is fine.

> I prefer that gitlab builds rely on gitlab branches, I have a few
> more fixes planned but removing relying on copr is a must IMHO.
> 

Yes, we are moving in that direction, I agree.

> Generating copr from gitlab builds makes sense indeed (@snir)
> 
> > Do you have a URL of results?
> 
> From the series:
>     https://gitlab.freedesktop.org/victortoso/vd_agent/pipelines/21572
> 
> > Frediano
>