[Spice-devel] [PATCH spice-protocol] error_codes: Remove obsolete header file

[Snir Sheriber]

Hi,

On 12/21/18 4:00 PM, Frediano Ziglio wrote:
> This file was used by the old client to hold return error codes.
>
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> ---
>   spice/Makefile.am   |  1 -
>   spice/error_codes.h | 51 ---------------------------------------------
>   spice/meson.build   |  1 -
>   3 files changed, 53 deletions(-)
>   delete mode 100644 spice/error_codes.h
>
> diff --git a/spice/Makefile.am b/spice/Makefile.am
> index e41f41d..69c9976 100644
> --- a/spice/Makefile.am
> +++ b/spice/Makefile.am
> @@ -7,7 +7,6 @@ spice_protocol_include_HEADERS =		\
>   	controller_prot.h			\
>   	end-packed.h				\
>   	enums.h					\
> -	error_codes.h				\
>   	foreign_menu_prot.h			\
>   	ipc_ring.h				\
>   	macros.h				\
> diff --git a/spice/error_codes.h b/spice/error_codes.h
> deleted file mode 100644
> index 9fcfe3f..0000000
> --- a/spice/error_codes.h
> +++ /dev/null
> @@ -1,51 +0,0 @@
> -/*
> -   Copyright (C) 2009 Red Hat, Inc.
> -
> -   Redistribution and use in source and binary forms, with or without
> -   modification, are permitted provided that the following conditions are
> -   met:
> -
> -       * Redistributions of source code must retain the above copyright
> -         notice, this list of conditions and the following disclaimer.
> -       * Redistributions in binary form must reproduce the above copyright
> -         notice, this list of conditions and the following disclaimer in
> -         the documentation and/or other materials provided with the
> -         distribution.
> -       * Neither the name of the copyright holder nor the names of its
> -         contributors may be used to endorse or promote products derived
> -         from this software without specific prior written permission.
> -
> -   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDER AND CONTRIBUTORS "AS
> -   IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED
> -   TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A
> -   PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
> -   HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
> -   SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
> -   LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
> -   DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
> -   THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
> -   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
> -   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> -*/
> -
> -#ifndef _H_SPICE_ERROR_CODES
> -#define _H_SPICE_ERROR_CODES
> -
> -#define SPICEC_ERROR_CODE_SUCCESS 0
> -#define SPICEC_ERROR_CODE_ERROR 1
> -#define SPICEC_ERROR_CODE_GETHOSTBYNAME_FAILED 2
> -#define SPICEC_ERROR_CODE_CONNECT_FAILED 3
> -#define SPICEC_ERROR_CODE_SOCKET_FAILED 4
> -#define SPICEC_ERROR_CODE_SEND_FAILED 5
> -#define SPICEC_ERROR_CODE_RECV_FAILED 6
> -#define SPICEC_ERROR_CODE_SSL_ERROR 7
> -#define SPICEC_ERROR_CODE_NOT_ENOUGH_MEMORY 8
> -#define SPICEC_ERROR_CODE_AGENT_TIMEOUT 9
> -#define SPICEC_ERROR_CODE_AGENT_ERROR 10
> -#define SPICEC_ERROR_CODE_VERSION_MISMATCH 11
> -#define SPICEC_ERROR_CODE_PERMISSION_DENIED 12
> -#define SPICEC_ERROR_CODE_INVALID_ARG 13
> -#define SPICEC_ERROR_CODE_CMD_LINE_ERROR 14
> -
> -#endif /* _H_SPICE_ERROR_CODES */
> -
> diff --git a/spice/meson.build b/spice/meson.build
> index 5b1ff30..05b2b28 100644
> --- a/spice/meson.build
> +++ b/spice/meson.build
> @@ -3,7 +3,6 @@ spice_protocol_headers = [
>     'controller_prot.h',
>     'end-packed.h',
>     'enums.h',
> -  'error_codes.h',
>     'foreign_menu_prot.h',
>     'ipc_ring.h',
>     'macros.h',


Fine with me. ack.