[Spice-devel] [PATCH spice-gtk] session: initialize USB device manager during init

marcandre.lureau at redhat.com marcandre.lureau at redhat.com
Wed Jan 2 11:30:15 UTC 2019


From: Marc-André Lureau <marcandre.lureau at redhat.com>

Simple command line tools simply connect all channels, however
usbredir channels require that the manager was previously
initialized. Currently, running spicy-stats on a VM with usbredir
channels prints:

(lt-spicy-stats:25224): GSpice-CRITICAL **: 14:30:54.724: spice_usbredir_channel_up: assertion 'priv->host != NULL' failed

(lt-spicy-stats:25224): GSpice-CRITICAL **: 14:30:54.724: usbredir_handle_msg: assertion 'priv->host != NULL' failed

There is not strong reason not to initialize the USB device manager
when the session is created.

(when usbredir isn't compiled in, those criticals aren't reached)

Fixes:
https://gitlab.freedesktop.org/spice/spice-gtk/issues/67

Signed-off-by: Marc-André Lureau <marcandre.lureau at redhat.com>
---
 src/spice-session.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/spice-session.c b/src/spice-session.c
index a2ed401..8f4becb 100644
--- a/src/spice-session.c
+++ b/src/spice-session.c
@@ -283,6 +283,7 @@ static void spice_session_init(SpiceSession *session)
     s->images = cache_image_new((GDestroyNotify)pixman_image_unref);
     s->glz_window = glz_decoder_window_new();
     update_proxy(session, NULL);
+    spice_usb_device_manager_get(session, NULL);
 }
 
 static void
-- 
2.20.1.2.gb21ebb671b



More information about the Spice-devel mailing list