[Spice-devel] [PATCH spice-gtk 1/3] meson: use 0.49 support for pie

[Christophe Fergeau]

On Wed, Jan 02, 2019 at 06:30:50AM -0500, Frediano Ziglio wrote:
> > On Sat, Dec 22, 2018 at 06:53:24PM +0400, marcandre.lureau at redhat.com wrote:
> > > From: Marc-André Lureau <marcandre.lureau at redhat.com>
> > > 
> > > Fixes
> > > WARNING: Use the 'pie' kwarg instead of passing '-fpie' manually to
> > > 'spice-client-glib-usb-acl-helper'
> > > 
> > > Signed-off-by: Marc-André Lureau <marcandre.lureau at redhat.com>
> > > ---
> > >  meson.build     |  2 +-
> > >  src/meson.build | 13 +++----------
> > >  2 files changed, 4 insertions(+), 11 deletions(-)
> > > 
> > > diff --git a/meson.build b/meson.build
> > > index 4e4bee8..67149e7 100644
> > > --- a/meson.build
> > > +++ b/meson.build
> > > @@ -4,7 +4,7 @@
> > >  project('spice-gtk', 'c',
> > >           version : run_command('build-aux/git-version-gen',
> > >           '${MESON_SOURCE_ROOT}/.tarball-version', check :
> > >           true).stdout().strip(),
> > >           license : 'LGPLv2.1',
> > > -         meson_version : '>= 0.47.2')
> > > +         meson_version : '>= 0.49')
> > 
> > I think I mentioned it before, but to this day meson 0.49 is 24 days
> > old. Even if this was enough time to get it landed in f29/f30, when we
> > decide to switch to using meson by default, we'll have to settle on a
> > widely available version rather than always jumping to the latest one.
> > 
> > Christophe
> > 
> 
> Is not clear, are you suggesting to just ignore the warning?

I'm only pointing out that *in the future* we cannot constantly update
the required meson version to something very new.
When we start avoiding too new meson versions, ignoring the warning (or
figuring a way to make some parts of meson.build conditional on the
meson version) would indeed be good enough in my opinion.
At the moment, meson is only an alternative way of building spice-gtk,
so it's probably acceptable to require 0.49. I only wanted to remind
everyone that some day, it will no longer be desirable to do this.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20190102/850c9e23/attachment.sig>