[Spice-devel] [PATCH spice-server 03/33] build: Detect Windows build and change some definitions

[Christophe Fergeau]

On Wed, Jan 02, 2019 at 08:07:22AM -0500, Frediano Ziglio wrote:
> > 
> > On Sat, Dec 22, 2018 at 09:56:38AM -0500, Frediano Ziglio wrote:
> > > 
> > > > Hi
> > > > 
> > > > On Fri, Dec 21, 2018 at 4:03 PM Frediano Ziglio <fziglio at redhat.com>
> > > > wrote:
> > > > >
> > > > > Windows needs some specific setting to use network.
> > > > >
> > > > > Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> > > > 
> > > > with neat below
> > > > Reviewed-by: Marc-André Lureau <marcandre.lureau at redhat.com>
> > > > 
> > > > > ---
> > > > >  configure.ac       | 18 +++++++++++++++++-
> > > > >  server/Makefile.am |  1 +
> > > > >  2 files changed, 18 insertions(+), 1 deletion(-)
> > > > >
> > > > > diff --git a/configure.ac b/configure.ac
> > > > > index 96e4e66c..a2a81cef 100644
> > > > > --- a/configure.ac
> > > > > +++ b/configure.ac
> > > > > @@ -68,6 +68,18 @@ case $host_cpu in
> > > > >          SPICE_WARNING([spice-server on non-x86_64 architectures has
> > > > >          not
> > > > >          been extensively tested])
> > > > >  esac
> > > > >
> > > > > +AC_MSG_CHECKING([for native Win32])
> > > > > +case "$host_os" in
> > > > > +     *mingw*|*cygwin*)
> > > > > +        os_win32=yes
> 
> Like
> 
> AC_DEFINE([_WIN32_WINNT], [0x600], [Minimal Win32 version])]
> 
> ??

Yes, looks good. By putting this in config.h, everything is centralized
in one place rather than sometimes being in Makefile.am, sometimes in
configure.ac.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20190102/cb05911e/attachment.sig>