[Spice-devel] [PATCH] use g_queue_free_full to free the queue

Snir Sheriber ssheribe at redhat.com
Wed Jan 2 15:41:52 UTC 2019


Signed-off-by: Snir Sheriber <ssheribe at redhat.com>
---
 src/channel-display-gst.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/src/channel-display-gst.c b/src/channel-display-gst.c
index 2c07f35..bd2a9ff 100644
--- a/src/channel-display-gst.c
+++ b/src/channel-display-gst.c
@@ -548,11 +548,7 @@ static void spice_gst_decoder_destroy(VideoDecoder *video_decoder)
         g_source_remove(decoder->timer_id);
     }
     g_mutex_clear(&decoder->queues_mutex);
-    SpiceGstFrame *gstframe;
-    while ((gstframe = g_queue_pop_head(decoder->decoding_queue))) {
-        free_gst_frame(gstframe);
-    }
-    g_queue_free(decoder->decoding_queue);
+    g_queue_free_full(decoder->decoding_queue, (GDestroyNotify)free_gst_frame);
     if (decoder->display_frame) {
         free_gst_frame(decoder->display_frame);
     }
-- 
2.19.1



More information about the Spice-devel mailing list