[Spice-devel] [PATCH spice-gtk] use G_TYPE_POINTER instead of GST_TYPE_PIPELINE

Frediano Ziglio fziglio at redhat.com
Thu Jan 3 14:52:58 UTC 2019


> 
> GST_TYPE_PIPELINE is undeclared when gstvideo is disabled
> 
> Signed-off-by: Snir Sheriber <ssheribe at redhat.com>

This fixes current CI which is doing this test.

Also removes this warning (I just got it):

  GISCAN   SpiceClientGLib-2.0.gir
<unknown>:: Warning: SpiceClientGLib: (Signal)gst-video-overlay: argument pipeline: Unresolved type: 'GstPipeline'

> ---
>  src/channel-display.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/channel-display.c b/src/channel-display.c
> index 2a1d9d1..b0fe57e 100644
> --- a/src/channel-display.c
> +++ b/src/channel-display.c
> @@ -476,7 +476,7 @@ static void
> spice_display_channel_class_init(SpiceDisplayChannelClass *klass)
>                       g_cclosure_user_marshal_BOOLEAN__POINTER,
>                       G_TYPE_BOOLEAN,
>                       1,
> -                     GST_TYPE_PIPELINE);
> +                     G_TYPE_POINTER);
>  
>      channel_set_handlers(SPICE_CHANNEL_CLASS(klass));
>  }

Otherwise,
Acked-by: Frediano Ziglio <fziglio at redhat.com>

I remember Christophe preferred the GstPipeline type instead of the simple pointer.

Frediano


More information about the Spice-devel mailing list