[Spice-devel] [PATCH spice-gtk] use G_TYPE_POINTER instead of GST_TYPE_PIPELINE

[Frediano Ziglio]

> 
> On Thu, Jan 03, 2019 at 04:46:29PM +0200, Snir Sheriber wrote:
> > GST_TYPE_PIPELINE is undeclared when gstvideo is disabled
> 
> I'd rahter that we keep using the more specific type. Feel free to have
> a
> #ifndef HAVE_GST_VIDEO
> #define GST_TYPE_PIPELINE G_TYPE_POINTER
> #endif

It sounds reasonable too

> but would that code be used at all if gstreamer is not in use?
> 

I think users of spice-glib that will connect the signal won't produce
a warning as signal would be missing so is worth registering the signal
even if you don't have GStreamer.

> Christophe
> 
> > 
> > Signed-off-by: Snir Sheriber <ssheribe at redhat.com>
> > ---
> >  src/channel-display.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/src/channel-display.c b/src/channel-display.c
> > index 2a1d9d1..b0fe57e 100644
> > --- a/src/channel-display.c
> > +++ b/src/channel-display.c
> > @@ -476,7 +476,7 @@ static void
> > spice_display_channel_class_init(SpiceDisplayChannelClass *klass)
> >                       g_cclosure_user_marshal_BOOLEAN__POINTER,
> >                       G_TYPE_BOOLEAN,
> >                       1,
> > -                     GST_TYPE_PIPELINE);
> > +                     G_TYPE_POINTER);
> >  
> >      channel_set_handlers(SPICE_CHANNEL_CLASS(klass));
> >  }

How to remove the warning:

  GISCAN   SpiceClientGLib-2.0.gir
<unknown>:: Warning: SpiceClientGLib: (Signal)gst-video-overlay: argument pipeline: Unresolved type: 'GstPipeline'

I have GStreamer enabled and installed while compiling but I get this warning,
maybe gir requires some additional option?

Frediano