[Spice-devel] [PATCH spice-gtk] display: add back SpiceDisplayChannel::streaming-mode

[Frediano Ziglio]

Actually was decided was an internal signal so we agreed to not keep it...

----- Original Message -----
> From: "Victor Toso" <victortoso at redhat.com>
> To: "marcandre lureau" <marcandre.lureau at redhat.com>
> Cc: spice-devel at lists.freedesktop.org
> Sent: Friday, 4 January, 2019 9:03:07 AM
> Subject: Re: [Spice-devel] [PATCH spice-gtk] display: add back SpiceDisplayChannel::streaming-mode
> 
> Hi,
> 
> On Fri, Jan 04, 2019 at 12:57:34PM +0400, marcandre.lureau at redhat.com wrote:
> > From: Marc-André Lureau <marcandre.lureau at redhat.com>
> > 
> > The signal was added in 0.35, but removed in
> > 8c5bf5dedab3cd5a9c7ac484c0d97d43aeb0056b. We should keep it for a
> > while with updated documentation and a G_SIGNAL_DEPRECATED flag.
> > 
> > Signed-off-by: Marc-André Lureau <marcandre.lureau at redhat.com>
> 
> Yes,
> Acked-by: Victor Toso <victortoso at redhat.com>
> 
> Thanks
> 
> > ---
> >  src/channel-display.c | 25 +++++++++++++++++++++++++
> >  1 file changed, 25 insertions(+)
> > 
> > diff --git a/src/channel-display.c b/src/channel-display.c
> > index 8c0fe5a..4445c9c 100644
> > --- a/src/channel-display.c
> > +++ b/src/channel-display.c
> > @@ -91,6 +91,7 @@ enum {
> >      SPICE_DISPLAY_INVALIDATE,
> >      SPICE_DISPLAY_MARK,
> >      SPICE_DISPLAY_GL_DRAW,
> > +    SPICE_DISPLAY_STREAMING_MODE,
> >      SPICE_DISPLAY_OVERLAY,
> >  
> >      SPICE_DISPLAY_LAST_SIGNAL,
> > @@ -455,6 +456,30 @@ static void
> > spice_display_channel_class_init(SpiceDisplayChannelClass *klass)
> >                       4,
> >                       G_TYPE_UINT, G_TYPE_UINT, G_TYPE_UINT, G_TYPE_UINT);
> >  
> > +    /**
> > +     * SpiceDisplayChannel::streaming-mode:
> > +     * @display: the #SpiceDisplayChannel that emitted the signal
> > +     * @streaming_mode: %TRUE when it's streaming mode
> > +     *
> > +     * Return: handle for the display window if possible
> > +     *
> > +     * The #SpiceDisplayChannel::streaming-mode signal is emitted when
> > +     * spice server is working in streaming mode.
> > +     *
> > +     * Since: 0.35
> > +     *
> > +     * Deprecated: 0.36: use #SpiceDisplayChannel::gst-video-overlay
> > +     * instead
> > +     **/
> > +    signals[SPICE_DISPLAY_STREAMING_MODE] =
> > +        g_signal_new("streaming-mode",
> > +                     G_OBJECT_CLASS_TYPE(gobject_class),
> > +                     G_SIGNAL_DEPRECATED, 0,
> > +                     NULL, NULL, NULL,
> > +                     G_TYPE_POINTER,
> > +                     1,
> > +                     G_TYPE_BOOLEAN);
> > +
> >      /**
> >       * SpiceDisplayChannel::gst-video-overlay:
> >       * @display: the #SpiceDisplayChannel that emitted the signal
> > --
> > 2.20.1.2.gb21ebb671b
> > 
> > _______________________________________________
> > Spice-devel mailing list
> > Spice-devel at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/spice-devel
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
>