[Spice-devel] [PATCH spice-server 3/33 v2] build: Detect Windows build and change some definitions

[Christophe Fergeau]

On Thu, Jan 03, 2019 at 12:15:02PM -0500, Frediano Ziglio wrote:
> > 
> > On Wed, Jan 02, 2019 at 02:58:45PM +0000, Frediano Ziglio wrote:
> > > Windows needs some specific setting to use network.
> > > 
> > > Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> > > ---
> > >  configure.ac | 20 +++++++++++++++++++-
> > >  1 file changed, 19 insertions(+), 1 deletion(-)
> > > 
> > > Changes since v1:
> > > - all changes in configure.ac
> > > 
> > > diff --git a/configure.ac b/configure.ac
> > > index 96e4e66c..afe0017d 100644
> > > --- a/configure.ac
> > > +++ b/configure.ac
> > > @@ -68,6 +68,20 @@ case $host_cpu in
> > >          SPICE_WARNING([spice-server on non-x86_64 architectures has not
> > >          been extensively tested])
> > >  esac
> > >  
> > > +AC_MSG_CHECKING([for native Win32])
> > > +case "$host_os" in
> > > +     *mingw*|*cygwin*)
> > > +        os_win32=yes
> > > +        dnl Some code requires at least Vista
> > > +        AC_DEFINE([_WIN32_WINNT], [0x600], [Minimal Win32 version])]
> > 
> > Can this be part of the commit which adds code which needs Vista
> > behaviour? This way git blame would tell which code started to require at
> > least
> > Vista.
> > 
> 
> AI_ADDRCONFIG in reds.c which is already in master.

I'd mention it in the comment I guess "AI_ADDRCONFIG and possibly some
other code require at least Vista"

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20190104/a7c69ade/attachment.sig>