[Spice-devel] [PATCH vd_agent_linux v2 1/7] vdagentd: Tell different tools that we are falling through

[Christophe Fergeau]

On Fri, Jan 04, 2019 at 08:36:59AM +0000, Frediano Ziglio wrote:
> Different tools (compilers or analysers) recognise missing break
> in switch as possible problems.
> Many recognise "fall through" comment to tell is wanted.

a "fall through" comment (I think), "to tell it is wanted"


Acked-by: Christophe Fergeau <cfergeau at redhat.com>

> 
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> ---
>  src/vdagentd/vdagentd.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/vdagentd/vdagentd.c b/src/vdagentd/vdagentd.c
> index a2f0946..ec679fd 100644
> --- a/src/vdagentd/vdagentd.c
> +++ b/src/vdagentd/vdagentd.c
> @@ -965,6 +965,7 @@ static void daemonize(void)
>      case -1:
>          syslog(LOG_ERR, "fork: %m");
>          retval = 1;
> +        // fall through
>      default:
>          udscs_destroy_server(server);
>          exit(retval);
> -- 
> 2.20.1
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20190104/5820d456/attachment.sig>