[Spice-devel] [PATCH spice-gtk 4/5] widget: gst_size_allocate() is static

Frediano Ziglio fziglio at redhat.com
Sat Jan 5 17:06:02 UTC 2019


The patch is good but the message is confusing, there's nothing wrong with
the current code and the function is static with or without that "static" on
the definition. 
Maybe "widget: Make clear gst_size_allocate() is static on definition" ?

I think the patch has nothing to do with the series.

> 
> From: Marc-André Lureau <marcandre.lureau at redhat.com>
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau at redhat.com>
> ---
>  src/spice-widget.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/spice-widget.c b/src/spice-widget.c
> index 87c1560..a44a6f1 100644
> --- a/src/spice-widget.c
> +++ b/src/spice-widget.c
> @@ -2601,7 +2601,7 @@ static gboolean gst_draw_event(GtkWidget *widget,
> cairo_t *cr, gpointer data)
>      return false;
>  }
>  
> -void gst_size_allocate(GtkWidget *widget, GdkRectangle *a, gpointer data)
> +static void gst_size_allocate(GtkWidget *widget, GdkRectangle *a, gpointer
> data)
>  {
>      SpiceDisplay *display = SPICE_DISPLAY(data);
>      SpiceDisplayPrivate *d = display->priv;

Frediano


More information about the Spice-devel mailing list