[Spice-devel] [PATCH spice-gtk 33/34] audio: use gstreamer by default

[Marc-André Lureau]

Hi

On Mon, Jan 7, 2019 at 8:22 PM Christophe Fergeau <cfergeau at redhat.com> wrote:
>
> On Mon, Jan 07, 2019 at 12:01:02PM +0400, marcandre.lureau at redhat.com wrote:
> > From: Marc-André Lureau <marcandre.lureau at redhat.com>
> >
> > The pulse backend is getting deprecated.
>
> Not sure this is something we should do right before a release rather
> than right after the release so that the gstreamer backend on linux gets
> a bit more testing than usual.

Imho, the gstreamer backend is quite mature. It is a bit unfortunate
that it has some issues with recording and pulsesrc, but this is not
really our fault, and we will lower the rank of the pulse elements.

Not a big deal if we decide to postpone it after v0.36 though

> Christophe
>
> >
> > Signed-off-by: Marc-André Lureau <marcandre.lureau at redhat.com>
> > ---
> >  src/spice-audio.c | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/src/spice-audio.c b/src/spice-audio.c
> > index daf62df..a03c80b 100644
> > --- a/src/spice-audio.c
> > +++ b/src/spice-audio.c
> > @@ -236,11 +236,11 @@ SpiceAudio *spice_audio_new_priv(SpiceSession *session, GMainContext *context,
> >      if (name == NULL)
> >          name = g_get_application_name();
> >
> > +    self = SPICE_AUDIO(spice_gstaudio_new(session, context, name));
> >  #ifdef HAVE_PULSE
> > -    self = SPICE_AUDIO(spice_pulse_new(session, context, name));
> > -#endif
> >      if (!self)
> > -        self = SPICE_AUDIO(spice_gstaudio_new(session, context, name));
> > +        self = SPICE_AUDIO(spice_pulse_new(session, context, name));
> > +#endif
> >      if (!self)
> >          return NULL;
> >
> > --
> > 2.20.1.2.gb21ebb671b
> >
> > _______________________________________________
> > Spice-devel mailing list
> > Spice-devel at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/spice-devel
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel



-- 
Marc-André Lureau