[Spice-devel] [PATCH spice-gtk 0/5] Require GStreamer, fix build warnings

[Victor Toso]

On Tue, Jan 08, 2019 at 02:41:22PM +0400, Marc-André Lureau wrote:
> Hi
> 
> On Tue, Jan 8, 2019 at 1:15 PM Victor Toso <victortoso at redhat.com> wrote:
> >
> > Hi,
> >
> > On Mon, Jan 07, 2019 at 11:30:55PM +0400, Marc-André Lureau wrote:
> > > > > In the future, yes! For now, use GStreamer by default if possible, and
> > > > > fallback on pulse.
> > > > >
> > > > > See also proposed implementation:
> > > > > "[PATCH spice-gtk 32/34] gst: check pulseaudio plugin version >= 1.15"
> > > > > "[PATCH spice-gtk 33/34] audio: use gstreamer by default"
> > >
> > > We have only GStreamer support for video, so let's make it required.
> > > There is no modularity needed at this point, it can be added when
> > > needed (although I would rather have less modularity in general,
> > > because of testing matrix, maintainance..).
> > >
> > > We would like to remove PulseAudio audio backend in the future, as it
> > > will be replaced by pipewire, and unnecessarily make us maintain
> > > different audio backends: GStreamer handles various audio backends for
> > > us, and we know it is quite solid since it is being used with the
> > > Windows build for a long while.
> > >
> > > Since we would like to release v0.36 soonish, and there are valid
> > > concerns that such a change now is a bit too risky, I propose to:
> > >
> > > - make GStreamer a blessed dependency in 0.36 for audio & video (since
> > > it is required for video decoding/overlay etc)
> > > - keep pulse audio backend as default, but add a warning at compile
> > > time that it will be deprecated in future releases
> > > - make GStreamer audio backend lower the rank of pulsesrc < 1.15 so
> > > alsa or other backends are chosen with higher priority
> >
> > Not sure if that's good. Because of one pulsesrc bug we could
> > likely have potential different scenarios per user on their bug
> > reports for audio related issues.
> 
> indeed, we will have to identify the GStreamer bugs and fix/reassign there.
> 
> But I much prefer having GStreamer taking care of the audio/video
> abstractions than spice-gtk!
> 
> > > - after 0.36, make GStreamer audo backend the default, and disable the
> > > pulse backend (unless explicetly --enable-pulse).
> >
> > Yes
> >
> > > - later on, remove the pulse audio backend
> >
> > Yep
> >
> > > Any comments?
> >
> > Besides being unsure about changing the rank of pulsesrc (I'd
> > simple prefer that distro's backport the fix or that we don't set
> > the volume before the audio stream is created).
> 
> I think it's unlikely the the fix will be backported to
> anything else than upcoming gst-good stable = 1.14.5
> 
> Not setting the volume before the audio stream is created is a bit
> hackish, we could perhaps workaround it, and watch for
> source-output-index update. I can give it a try, but that seems
> fragile to me.

Well, setting the rank will be temporary anyway so, I don't think
is needed to workaround it if that seems problematic.

> > We will need a spice-protocol release too...
> 
> right, anything preventing a 0.12.15 release?

Not really, just a comment :)

Cheers,
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20190108/6df094d8/attachment.sig>