[Spice-devel] [PATCH spice-server v3 02/32] red-replay-qxl: Use PRIxPTR constant for string formatting

Christophe Fergeau cfergeau at redhat.com
Tue Jan 8 11:42:29 UTC 2019


Acked-by: Christophe Fergeau <cfergeau at redhat.com>

On Mon, Jan 07, 2019 at 06:01:45PM +0000, Frediano Ziglio wrote:
> These constants are meant to be used in format string for pointers
> types. Use them for portability.
> 
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> ---
>  server/red-replay-qxl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/server/red-replay-qxl.c b/server/red-replay-qxl.c
> index 9b63d237..4884e97e 100644
> --- a/server/red-replay-qxl.c
> +++ b/server/red-replay-qxl.c
> @@ -227,7 +227,7 @@ static replay_t read_binary(SpiceReplay *replay, const char *prefix, size_t *siz
>      uint8_t *zlib_buffer;
>      z_stream strm;
>  
> -    snprintf(template, sizeof(template), "binary %%d %s %%ld:%%n", prefix);
> +    snprintf(template, sizeof(template), "binary %%d %s %%" PRIdPTR ":%%n", prefix);
>      replay_fscanf_check(replay, template, &with_zlib, size, &replay->end_pos);
>      if (replay->error) {
>          return REPLAY_ERROR;
> -- 
> 2.20.1
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20190108/ca873943/attachment.sig>


More information about the Spice-devel mailing list