[Spice-devel] [PATCH spice-common v2 1/2] test-region: Add missing dependencies

[Frediano Ziglio]

> On Mon, Dec 17, 2018 at 06:56:19AM -0500, Frediano Ziglio wrote:
> > > 
> > > The test uses both GLib and pixman libraries.
> > > This does not seem to affect Linux but make the test fails under Windows.
> > > 
> > > Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> > > ---
> > >  tests/Makefile.am | 1 +
> > >  1 file changed, 1 insertion(+)
> > > 
> > > Changes since v1:
> > > - use SPICE_COMMON_LIBS
> > > 
> > > diff --git a/tests/Makefile.am b/tests/Makefile.am
> > > index 926ac99..f54e394 100644
> > > --- a/tests/Makefile.am
> > > +++ b/tests/Makefile.am
> > > @@ -63,6 +63,7 @@ test_region_CFLAGS =			\
> > >  	$(NULL)
> > >  test_region_LDADD =					\
> > >  	$(top_builddir)/common/libspice-common.la	\
> > > +	$(SPICE_COMMON_LIBS)				\
> > >  	$(NULL)
> > >  
> > >  # Avoid need for python(pyparsing) by end users
> > 
> > Looks like a bug in libtool. Dependencies are in libspice-common.la and
> > the real executable (in tests/.libs/test_region.exe) correctly depends
> > on glib and pixman dll files however the wrapper/launcher generated in
> > tests/test_region.exe is generated not considering dependencies in
> > libspice-common.la (one of wrapper job is to add some definitions to
> > PATH variable).
> > Still the patch solves the weird issue.
> 
> Actually, since test-region.c uses both pixman and glib, it should be
> linking with glib/pixman explicitly, not through libspice-common.la,
> it's a bug in our Makefile.am that it's not doing so.
> 
> Acked-by: Christophe Fergeau <cfergeau at redhat.com>
> 

Ok, so it's not a libtool bug although the final behaviour is weird.
Executable is linked but the wrapper doesn't add directories to PATH.

Frediano