[Spice-devel] [PATCH spice-gtk 20/34] meson: switch lz4 option to auto feature

Christophe Fergeau cfergeau at redhat.com
Tue Jan 8 13:57:35 UTC 2019


On Tue, Jan 08, 2019 at 05:30:46PM +0400, Marc-André Lureau wrote:
> On Tue, Jan 8, 2019 at 12:58 PM Christophe Fergeau <cfergeau at redhat.com> wrote:
> >
> > On Mon, Jan 07, 2019 at 11:19:11PM +0400, Marc-André Lureau wrote:
> > > Hi
> > >
> > > On Mon, Jan 7, 2019 at 7:58 PM Christophe Fergeau <cfergeau at redhat.com> wrote:
> > > >
> > > > On Mon, Jan 07, 2019 at 12:00:49PM +0400, marcandre.lureau at redhat.com wrote:
> > > > > From: Marc-André Lureau <marcandre.lureau at redhat.com>
> > > > >
> > > > > Contrary to spice server dependency, spice-gtk doesn't have a known
> > > > > minimum version requirement.
> > > >
> > > > Ideally, we'd still check for some not very old liblz4 to avoid compile
> > > > time failures, but the weird versioning does not make that easy :(
> > >
> > > Indeed, so do you ack that patch or you have more concerns about it?
> >
> > Is it too tricky to keep the existing check?
> 
> If it's not used or tested, it's just annoying and might be broken.
> 
> It looks like all distros we care about have >= v1.7.3
> https://repology.org/metapackage/lz4/versions

Ok, let's give this a try.. ;)

Acked-by: Christophe Fergeau <cfergeau at redhat.com>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20190108/6a1ee5f2/attachment.sig>


More information about the Spice-devel mailing list