[Spice-devel] [spice-gtk v2] gtk-session: do not request guest's clipboard data unnecessarily

[james harvey]

On Tue, Jan 8, 2019 at 11:13 PM james harvey <jamespharvey20 at gmail.com> wrote:
> v1 of your patch works extremely well for me.  I've been running it
> since Dec 14.

I'm about to start using the .patch files you emailed today, but
giving a few follow-ups first, still regarding v1.

> If I have a single spice client open, it works the majority of the
> time, but not as well as v1.
>
> When it usually works: https://termbin.com/0m7d
> * From a single CTRL+V, 2 sets of "clipboard get" and "Do not
> request..."  Not sure why there are 2 rather than 1.

Using v1, I see 2 "clipboard get" as well, but of course each with "got data".

> If I have more than one spice client open, it acts about as badly as
> without any patch.  ...
>
> When it rarely works: https://termbin.com/awsw

Using v1 now...

> * From a single CTRL+C:
> ** On the client being used, 4 sets of "clipboard get", showing "Do
> not request..."

2 "clipboard get" with "got data"

> ** On the client not being used, "inputs", "clipboard_get_targets",
> and "Failed to retrieve clipboard text"

"inputs", "clipboard_get_targets", but no "Failed to retrieve clipboard text"

> * From a single CTRL+V
> ** On the client being used, 4 sets of "clipboard get", showing "Do
> not request..."

"clipboard_clear", 3 sets of "clipboard get" with "got data"

> ** On the client not being used, "inputs", "clipboard_get_targets",
> "Retrieving the clipboard data has failed", "Failed to retrieve
> clipboard text"

"inputs", "clipboard_get_targets", "Retrieving the clipboard data has failed"

> Please let me know if it looks like this crash is related to the
> clipboard problems, or if I should create a bug report on it.  My best
> guess is it's related to the clipboard problems.  I'm going back to
> the v1 patch, but will do so on top of current git (dbdf692) to try to
> see if I get any more crashing.

I'm more confused on this now.  After sending the email, I reproduced
a few more identical crashes using v2 of the patch.  I went back to v1
on top of current git (dbdf692), and had gotten 18 hours using that
without any crashing.  I was literally typing this part of this email
and was saying it must be v2 causing the crash.  Then, I had an
identical crash.  So, it's not v2.  No idea how it lasted 18 hours
then now crashed.  I was away for 10 hours, but 8 of the 18 the host
(running the client) was being used, and occasionally the VM's.