[Spice-devel] [PATCH spice-server 2/3 v2] Allows to enable recorder integration

[Frediano Ziglio]

> 
> Hi,
> 
> On Wed, Dec 12, 2018 at 10:13:27AM +0000, Frediano Ziglio wrote:
> > recorder library will be used to collect some statistics during
> > development.
> 
> If we use RECORDER() like in the following commit, doesn't it
> mean this becomes a hard dependency? As you are mentioning using
> this library 'during development', do you plan to remove them
> before a release or something else?
> 
> Cheers,
> 

SPICE_CHECK_RECORDER adds an option disabled by default.
If the option is disabled the code is replaced by dummy code
doing nothing that the compiler will strip out.

> > Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> > ---
> >  configure.ac             | 1 +
> >  meson_options.txt        | 5 +++++
> >  subprojects/spice-common | 2 +-
> >  3 files changed, 7 insertions(+), 1 deletion(-)
> > 
> > diff --git a/configure.ac b/configure.ac
> > index 96e4e66c..903993a1 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -134,6 +134,7 @@ AX_VALGRIND_CHECK
> >  
> >  SPICE_CHECK_LZ4
> >  SPICE_CHECK_SASL
> > +SPICE_CHECK_RECORDER
> >  AM_CONDITIONAL(HAVE_SASL, test "x$have_sasl" = "xyes")
> >  
> >  dnl
> >  =========================================================================
> > diff --git a/meson_options.txt b/meson_options.txt
> > index 9568c97e..49f59cc4 100644
> > --- a/meson_options.txt
> > +++ b/meson_options.txt
> > @@ -45,3 +45,8 @@ option('manual',
> >      type : 'boolean',
> >      value : true,
> >      description : 'Build SPICE manual')
> > +
> > +option('recorder',
> > +    type : 'boolean',
> > +    value : false,
> > +    description: 'Enable recorder instrumentation')
> > diff --git a/subprojects/spice-common b/subprojects/spice-common
> > index 125cfa7f..1eb3771e 160000
> > --- a/subprojects/spice-common
> > +++ b/subprojects/spice-common
> > @@ -1 +1 @@
> > -Subproject commit 125cfa7fb2493060419c79eae3b40dbc499bd3db
> > +Subproject commit 1eb3771eeb00a09c20f1640700994fe5924fcdb9