[Spice-devel] [vdagent-linux] systemd: Update path in unit file

[Christophe Fergeau]

Hey,

On Mon, Jan 14, 2019 at 06:28:28AM -0500, Frediano Ziglio wrote:
> > 
> > From: Christian Hesse <mail at eworm.de>
> > 
> > When loading the unit file, systemd 240 logs:
> > 
> > systemd[1]: /usr/lib/systemd/system/spice-vdagentd.service:9: PIDFile=
> > references path below legacy directory /var/run/, updating
> > /var/run/spice-vdagentd/spice-vdagentd.pid →
> > /run/spice-vdagentd/spice-vdagentd.pid; please update the unit file
> > accordingly.
> > 
> > So update the path.
> > 
> > Signed-off-by: Christian Hesse <mail at eworm.de>
> > ---
> >  data/spice-vdagentd.service | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/data/spice-vdagentd.service b/data/spice-vdagentd.service
> > index 365b2c1..9c70b30 100644
> > --- a/data/spice-vdagentd.service
> > +++ b/data/spice-vdagentd.service
> > @@ -7,7 +7,7 @@ Requires=spice-vdagentd.socket
> >  Type=forking
> >  EnvironmentFile=-/etc/sysconfig/spice-vdagentd
> >  ExecStart=/usr/sbin/spice-vdagentd $SPICE_VDAGENTD_EXTRA_ARGS
> > -PIDFile=/var/run/spice-vdagentd/spice-vdagentd.pid
> > +PIDFile=/run/spice-vdagentd/spice-vdagentd.pid
> >  PrivateTmp=true
> >  Restart=on-failure
> >  
> 
> Isn't this breaking old systems?
> Maybe there's a way to get the proper directory for the system
> you are compiling?
> I cannot find an option with pkg-config and systemd/libsystemd.

I would say it's fine, systemd started using /run
in https://github.com/systemd/systemd/commit/2b583ce657
which is systemd 21 released 8 years ago.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20190114/11004e89/attachment.sig>