[Spice-devel] [spice-gtk PATCH v1] win-usb-dev: Set UsbDk backend on libusb 1.0.22

[Uri Lublin]

On 1/10/19 7:08 PM, Victor Toso wrote:
> Hi,
> 
> On Thu, Jan 10, 2019 at 12:51:04PM +0200, Yuri Benditovich wrote:
>> On Wed, Jan 9, 2019 at 3:35 PM Uri Lublin <uril at redhat.com> wrote:
>>
>>> On 1/9/19 3:30 PM, Yuri Benditovich wrote:
>>>>
>>>>
>>>> On Tue, Jan 8, 2019 at 3:09 PM Uri Lublin <uril at redhat.com
>>>> <mailto:uril at redhat.com>> wrote:
>>>>
>>>>      On 1/8/19 1:35 PM, Christophe Fergeau wrote:
>>>>       > On Tue, Jan 08, 2019 at 11:02:04AM +0200, Uri Lublin wrote:
>>>>       >> win-usb-dev also uses libusb.
>>>>       >> Similar to commit 3e23fff9, set libusb backend to UsbDk.
>>>>       >> Without this patch usb devices are not seen by win-usb-dev
>>>>       >> (windows clients), when UsbDk driver is installed.
>>>>       >>
>>>>       >> Signed-off-by: Uri Lublin <uril at redhat.com <mailto:
>>> uril at redhat.com>>
>>>>       >> ---
>>>>       >>
>>>>       >> Additionally I think the code need to check that usbdk driver
>>>>       >> is indeed installed before setting the backend.
>>>>       >
>>>>       > Isn't this
>>>>       > https://gitlab.freedesktop.org/spice/spice-gtk/commit/8c0fdcbc ?
>>>>
>>>>      Yes, it is, sorry.
>>>>
>>>>      As mentioned above, I think we should do it only if usbdk driver
>>>>      is indeed installed.
>>>>
>>>>
>>>> What shall we do if usbdk is not installed?
>>>
>>> I have a patch that checks if usbdk is installed.
>>> I'll send it later.
>>>
>>
>> The question is different: let's say the usbdk is not installed. What we
>> do? Work with existing backend? If so, this should be covered in testing
>> and we should  declare that spice-gtk supports also other backends. Correct?
> 
> Is there any interest in using anything else then UsbDk for
> spice? IMHO, UsbDk is what we support and we could simply disable
> usb redirection if UsbDk driver is not installed present at
> runtime.

Yes, I agree with both of you.

Uri.