[Spice-devel] [PATCH vd_agent_linux 1/7] file-xfers: Initialise correctly AgentFileXferTask::file_fd field

[Victor Toso]

Hi,

For some reason I miss in my inbox the 6/7 patch. Looking at,
seems that mailman got it.

    https://lists.freedesktop.org/archives/spice-devel/2019-January/047268.html

My only suggestion is to move the test to root directory instead
of srcdir. I'd prefer also to use the glib test framework [0] but
tbh, from basically zero tests to 1, we can improve later if
needed :)

[0] https://developer.gnome.org/glib/stable/glib-Testing.html

Besides the location for the test, for the series
Acked-by: Victor Toso <victortoso at redhat.com>

On Tue, Jan 15, 2019 at 06:49:56PM +0000, Frediano Ziglio wrote:
> Correct invalid value for a file descriptor is -1, not 0.
> 
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> ---
>  src/vdagent/file-xfers.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/vdagent/file-xfers.c b/src/vdagent/file-xfers.c
> index b5aedd0..78d5db3 100644
> --- a/src/vdagent/file-xfers.c
> +++ b/src/vdagent/file-xfers.c
> @@ -133,6 +133,7 @@ static AgentFileXferTask *vdagent_parse_start_msg(
>          goto error;
>      }
>      task = g_new0(AgentFileXferTask, 1);
> +    task->file_fd = -1;
>      task->id = msg->id;
>      task->file_name = g_key_file_get_string(
>          keyfile, "vdagent-file-xfer", "name", &error);
> -- 
> 2.20.1
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20190116/9657dcde/attachment.sig>