[Spice-devel] [PATCH] drm: Split out drm_probe_helper.h
Sam Ravnborg
sam at ravnborg.org
Wed Jan 16 18:10:18 UTC 2019
Hi Daniel.
> v5: Actually try to sort them, and while at it, sort all the ones I
> touch.
Applied this variant on top of drm-misc and did a build test.
Looked good for ia64, x86 and alpha.
Took a closer look at the changes to atmel_hlcd - and they looked OK.
But I noticed that atmel_hlcdc uses only drm_kms_helper_poll_init() and
drm_kms_helper_poll_fini().
But there are no hits on DRM_CONNECTOR_POLL - so I think we maybe
have a driver here where we have plugged the drm_poll infrastructure,
but it is not in use.
> include/drm/drm_crtc_helper.h | 16 -----------
The list of include files in this file could be dropped and replaced by:
struct drm_connector;
struct drm_device;
struct drm_display_mode;
struct drm_encoder;
struct drm_framebuffer;
struct drm_mode_set;
struct drm_modeset_acquire_ctx;
I tried to do so on top of your patch.
But there were too many build errros and I somehow lost the motivation.
> include/drm/drm_probe_helper.h | 27 +++++++++++++++++++
This on the other hand is fine - as expected as this is a new file.
But the above is just some random comments so:
Acked-by: Sam Ravnborg <sam at ravnborg.org>
More information about the Spice-devel
mailing list