[Spice-devel] [PATCH spice-common] quic: fix sign-compare warning

marcandre.lureau at redhat.com marcandre.lureau at redhat.com
Wed Jan 16 23:27:02 UTC 2019


From: Marc-André Lureau <marcandre.lureau at redhat.com>

../subprojects/spice-common/common/quic.c: In function 'fill_model_structures':
../subprojects/spice-common/common/quic.c:695:55: error: comparison of integer expressions of different signedness: 'int' and 'unsigned int' [-Werror=sign-compare]
     spice_assert(free_counter - family_stat->counters == nbuckets * ncounters);
                                                       ^~

Signed-off-by: Marc-André Lureau <marcandre.lureau at redhat.com>
---
 common/quic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/quic.c b/common/quic.c
index c28974e..1760274 100644
--- a/common/quic.c
+++ b/common/quic.c
@@ -692,7 +692,7 @@ static void fill_model_structures(SPICE_GNUC_UNUSED Encoder *encoder, FamilyStat
         bnumber++;
     } while (bend < levels - 1);
 
-    spice_assert(free_counter - family_stat->counters == nbuckets * ncounters);
+    spice_assert(free_counter - family_stat->counters == (ptrdiff_t)(nbuckets * ncounters));
 }
 
 static void find_model_params(Encoder *encoder,
-- 
2.20.1.98.gecbdaf0899



More information about the Spice-devel mailing list