[Spice-devel] [PATCH spice-common] meson: fix building for big-endian host

[Marc-André Lureau]

Hi

On Thu, Jan 17, 2019 at 12:15 PM Frediano Ziglio <fziglio at redhat.com> wrote:
>
> >
> > From: Marc-André Lureau <marcandre.lureau at redhat.com>
> >
> > autofoo build-sys defines WORDS_BIGENDIAN, and spice-common code uses it.
> >
> > Later, I think it would make sense to switch to G_BIG_ENDIAN instead.
> >
>
> This comment should not be in the commit message.
>
> IMHO WORDS_BIGENDIAN is fine, is pretty standard and Meson is currently
> providing definitions in the Autoconf style as it's quite standard.

WORDS_BIGENDIAN is standard?

meson doesn't provide it.

>
> > Fixes:
> > https://gitlab.freedesktop.org/spice/spice-common/issues/2
> >
> > Signed-off-by: Marc-André Lureau <marcandre.lureau at redhat.com>
> > ---
> >  meson.build | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/meson.build b/meson.build
> > index 049409b..8579680 100644
> > --- a/meson.build
> > +++ b/meson.build
> > @@ -33,6 +33,9 @@ spice_common_config_data = configuration_data()
> >  if get_option('extra-checks')
> >    spice_common_config_data.set('ENABLE_EXTRA_CHECKS', '1')
> >  endif
> > +if host_machine.endian() == 'big'
> > +  spice_common_config_data.set('WORDS_BIGENDIAN', '1')
> > +endif
> >
> >  spice_common_generate_code = get_option('generate-code')
> >  spice_common_generate_client_code = spice_common_generate_code == 'all' or
> >  spice_common_generate_code == 'client'
>
> Frediano
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel



-- 
Marc-André Lureau