[Spice-devel] [PATCH spice-common] meson: fix building for big-endian host

[Marc-André Lureau]

Hi

On Thu, Jan 17, 2019 at 12:35 PM Frediano Ziglio <fziglio at redhat.com> wrote:
>
> >
> > Hi
> >
> > On Thu, Jan 17, 2019 at 12:15 PM Frediano Ziglio <fziglio at redhat.com> wrote:
> > >
> > > >
> > > > From: Marc-André Lureau <marcandre.lureau at redhat.com>
> > > >
> > > > autofoo build-sys defines WORDS_BIGENDIAN, and spice-common code uses it.
> > > >
> > > > Later, I think it would make sense to switch to G_BIG_ENDIAN instead.
> > > >
> > >
> > > This comment should not be in the commit message.
> > >
> > > IMHO WORDS_BIGENDIAN is fine, is pretty standard and Meson is currently
> > > providing definitions in the Autoconf style as it's quite standard.
> >
> > WORDS_BIGENDIAN is standard?
> >
>
> I didn't say that, please read my sentence again.
>
> > meson doesn't provide it.
> >
>
> I know... so?
> Programs have been using it for decades.
> Same apply to HAVE_xxx or ENABLE_yyy.

What I mean is that it is simpler to use G_BYTE_ORDER == G_BIG_ENDIAN,
since it's part of glib headers. You don't need a configure-time
check.

This bug wouldn't exist.

>
> > >
> > > > Fixes:
> > > > https://gitlab.freedesktop.org/spice/spice-common/issues/2
> > > >
> > > > Signed-off-by: Marc-André Lureau <marcandre.lureau at redhat.com>
> > > > ---
> > > >  meson.build | 3 +++
> > > >  1 file changed, 3 insertions(+)
> > > >
> > > > diff --git a/meson.build b/meson.build
> > > > index 049409b..8579680 100644
> > > > --- a/meson.build
> > > > +++ b/meson.build
> > > > @@ -33,6 +33,9 @@ spice_common_config_data = configuration_data()
> > > >  if get_option('extra-checks')
> > > >    spice_common_config_data.set('ENABLE_EXTRA_CHECKS', '1')
> > > >  endif
> > > > +if host_machine.endian() == 'big'
> > > > +  spice_common_config_data.set('WORDS_BIGENDIAN', '1')
> > > > +endif
> > > >
> > > >  spice_common_generate_code = get_option('generate-code')
> > > >  spice_common_generate_client_code = spice_common_generate_code == 'all'
> > > >  or
> > > >  spice_common_generate_code == 'client'
> > >
>
> Frediano



-- 
Marc-André Lureau