[Spice-devel] [PATCH spice-common] quic: fix sign-compare warning

[Marc-André Lureau]

Hi

On Thu, Jan 17, 2019 at 12:19 PM Frediano Ziglio <fziglio at redhat.com> wrote:
>
> >
> > From: Marc-André Lureau <marcandre.lureau at redhat.com>
> >
> > ../subprojects/spice-common/common/quic.c: In function
> > 'fill_model_structures':
> > ../subprojects/spice-common/common/quic.c:695:55: error: comparison of
> > integer expressions of different signedness: 'int' and 'unsigned int'
> > [-Werror=sign-compare]
> >      spice_assert(free_counter - family_stat->counters == nbuckets *
> >      ncounters);
>
> OT: is it a 32 bit architecture? Why a pointer difference is "int" ?

Yes, on 32 bit architecture. But I don't know the details, ie why it
doesn't warn on 64 bit.

>
> >                                                        ^~
> >
> > Signed-off-by: Marc-André Lureau <marcandre.lureau at redhat.com>
>
> Acked-by: Frediano Ziglio <figlio at redhat.com>

thanks

>
> > ---
> >  common/quic.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/common/quic.c b/common/quic.c
> > index c28974e..1760274 100644
> > --- a/common/quic.c
> > +++ b/common/quic.c
> > @@ -692,7 +692,7 @@ static void fill_model_structures(SPICE_GNUC_UNUSED
> > Encoder *encoder, FamilyStat
> >          bnumber++;
> >      } while (bend < levels - 1);
> >
> > -    spice_assert(free_counter - family_stat->counters == nbuckets *
> > ncounters);
> > +    spice_assert(free_counter - family_stat->counters ==
> > (ptrdiff_t)(nbuckets * ncounters));
> >  }
> >
> >  static void find_model_params(Encoder *encoder,
>
> Frediano
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel



-- 
Marc-André Lureau